Photos and images with lots of colors are best saved in JPEG. But you should remember that the JPEG compression algorithm compresses images with loss of quality.
Icons, schemes, pictures with lots of text and images with transparency are best saved in PNG. PNG compression algorithm compresses images with no loss of quality.