Stella,


For your 50D I would recommend:


Canon EF-S 17-55mm f/2.8 IS USM Lens


Tamron 17-50mm f/2.8 XR Di II Lens